Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ColumnarValue operations #331

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Oct 31, 2024

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

To prepare to remove table_length from ProofExpr::result_evaluate and return ColumnarValue we need to add operations on ColumnarValue.

What changes are included in this PR?

  • add comparison operations on ColumnarValue.
  • add numerical operations on ColumnarValue.

Are these changes tested?

Will be tested in a future PR.

@iajoiner iajoiner force-pushed the feat/columnar-value-operations branch from 966efb9 to 44cce69 Compare October 31, 2024 22:03
@iajoiner iajoiner requested a review from JayWhite2357 October 31, 2024 22:03
@iajoiner iajoiner marked this pull request as ready for review October 31, 2024 22:03
@iajoiner iajoiner force-pushed the feat/columnar-value-operations branch 2 times, most recently from 43db4e4 to db6f6f1 Compare November 1, 2024 13:17
@iajoiner iajoiner force-pushed the feat/columnar-value-operations branch from db6f6f1 to d32a469 Compare November 1, 2024 13:44
@iajoiner iajoiner marked this pull request as draft November 1, 2024 21:18
@iajoiner iajoiner marked this pull request as ready for review November 3, 2024 05:04
@iajoiner iajoiner requested a review from JayWhite2357 November 4, 2024 14:28
@iajoiner iajoiner force-pushed the feat/columnar-value-operations branch from 6178bc8 to 9b7b7d5 Compare November 4, 2024 14:36
@iajoiner iajoiner enabled auto-merge November 4, 2024 14:58
@iajoiner iajoiner merged commit 36d9ae3 into main Nov 4, 2024
12 checks passed
Copy link

github-actions bot commented Nov 4, 2024

🎉 This PR is included in version 0.35.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@iajoiner iajoiner deleted the feat/columnar-value-operations branch November 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants