Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand column_operation.rs to include column-literal operations #332

Open
2 tasks
iajoiner opened this issue Nov 1, 2024 · 0 comments
Open
2 tasks

Expand column_operation.rs to include column-literal operations #332

iajoiner opened this issue Nov 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Nov 1, 2024

Background and Motivation

We need to expand column_operation.rs to include column-literal operations so that we can define accurate and fast operations on ColumnarValues.

Changes Required

  • Add the following functions to column_operation.rs or start a separate column_literal_operation.rs.
  • Make sure the code is well tested.

Examples of functions we need:

pub(super) fn slice_literal_and(slice: &[bool], lit: bool) -> Vec<bool>;
pub(super) fn slice_literal_or(slice: &[bool], lit: bool) -> Vec<bool>;
pub(super) fn slice_literal_eq<T>(slice: &[T], lit: T) -> Vec<T>
where
    T: PartialEq + Debug;
pub(super) fn slice_literal_le_casting_slice<SmallerType, LargerType>(
    slice_of_smaller_type: &[SmallerType],
    literal_of_larger_type: LargerType,
) -> Vec<bool>
where
    SmallerType: Copy + Debug + Into<LargerType>,
    LargerType: PartialOrd + Copy + Debug;
pub(super) fn slice_literal_le_casting_literal<SmallerType, LargerType>(
    slice_of_larger_type: &[LargerType],
    literal_of_smaller_type: SmallerType,
) -> Vec<bool>
where
    SmallerType: Copy + Debug + Into<LargerType>,
    LargerType: PartialOrd + Copy + Debug;
@iajoiner iajoiner added the enhancement New feature or request label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant