feat: change client id generation for connectors central components #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: Does previously generated clientIds need to be converted to the new format? |
Negative, the DAPS doesn't really care what the clientId is, as long as it is unique and that's covered by both the old and the new "generation" method |
kamilczaja
approved these changes
Dec 10, 2024
PaddseL
deleted the
327-change-client-id-generation-for-connectors-central-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR close?
Closes #327
Checklist
This seems to be the only relevant piece of code to change. I decided to leave the function for generation in place, if there are changes to the generation of the clientId in the future, only this has to be changed again. Please provide feedback especially for the tests, if they make sense at all or maybe are at the wrong place.