feat: change client id generation for connectors central components (#…

…394) * feat(ClientIdUtils): use connectorId as clientId as it is * test: make sure that connectorId equals clientId * docs: update CHANGELOG.md
sovity · Dec 10, 2024 · 759c9e8 · 759c9e8
1 parent 82d1e1d
commit 759c9e8
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ please see [changelog_updates.md](docs/dev/changelog_updates.md).
 - Fixed an issue wherein it was possible to bypass the CaaS request limit in an organization ([PR #384](https://github.com/sovity/authority-portal/pull/384))
 - Fixed an issue wherein a user registration could fail due to a mismatch of the internal database and the Keycloak database
 - Fixed an issue where entries in the connector overview would randomly switch places ([PR #386](https://github.com/sovity/authority-portal/pull/386))
+- Changed Client ID generation for Connectors & Central Components ([#327](https://github.com/sovity/authority-portal/issues/327))
 
 ### Known issues
 

diff --git a/...quarkus/src/main/kotlin/de/sovity/authorityportal/web/utils/idmanagement/ClientIdUtils.kt b/...quarkus/src/main/kotlin/de/sovity/authorityportal/web/utils/idmanagement/ClientIdUtils.kt
@@ -26,8 +26,6 @@ class ClientIdUtils {
 
     fun generateFromConnectorId(connectorId: String): String {
         return connectorId
-            .replace(".", "-")
-            .lowercase(Locale.getDefault())
     }
 
     fun exists(clientId: String): Boolean {

diff --git a/...in/de/sovity/authorityportal/web/tests/services/connector/CaasManagementApiServiceTest.kt b/...in/de/sovity/authorityportal/web/tests/services/connector/CaasManagementApiServiceTest.kt
@@ -154,6 +154,7 @@ class CaasManagementApiServiceTest {
             .withOffsetDateTimeComparator()
             .withStrictTypeChecking()
             .isEqualTo(expected.copy())
+        assertThat(actual.connectorId).isEqualTo(actual.clientId)
     }
 
     @Test

diff --git a/.../sovity/authorityportal/web/tests/services/connector/ConnectorManagementApiServiceTest.kt b/.../sovity/authorityportal/web/tests/services/connector/ConnectorManagementApiServiceTest.kt
@@ -547,6 +547,7 @@ class ConnectorManagementApiServiceTest {
             .withOffsetDateTimeComparator()
             .withStrictTypeChecking()
             .isEqualTo(expected.copy())
+        assertThat(actual.connectorId).isEqualTo(actual.clientId)
     }
 
     @Test