WIP: Fix issues on Windows and add CI testing #448
+26
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Afaik Windows was not a supported platform before, at least it was not in the supports or in the readme. So super interesting that it worked before, but I suppose we will have to exclude some of the tests for Windows as test with a uid will never pass I think. Maybe we can try replacing that with a SID, although I am not sure if you are allowed to chose your own SID. I thought Windows always generated that. |
ramereth
force-pushed
the
fix-windows
branch
2 times, most recently
from
8a0d162
to
e828fb8
Compare
Signed-off-by: Lance Albertson <[email protected]>
ramereth
force-pushed
the
fix-windows
branch
from
e828fb8
to
889d441
Compare
|
In the latest release from PR #467 I updated the CI pipeline and added windows but it failed due to some more linux specific settings in code. Looks to be more work that will need to go into supporting windows then just adding it to CI workflow. |
Signed-off-by: Corey Hemminger <[email protected]>
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.