Fix users_manage usage in kitchen-tests #11181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of data bags in the users cookbook was removed in 6.0.0 [1]. This applies the recommended workaround and allow the integration tests to pass. [1] https://github.com/sous-chefs/users/blob/master/CHANGELOG.md#600---2021-03-12 Signed-off-by: Lance Albertson <[email protected]>
ramereth
force-pushed
the
fix-users-manage
branch
from
f5515e0
to
543289e
Compare
lamont-granquist
approved these changes
Mar 15, 2021
|
@ramereth can you backport this one as well? |
|
Looks like I need to make an adjustment on MacOS. I'll see about pushing an additional fix for that. |
|
mac and windows, that's weird |
|
I think I have a fix for macos, I'm working on resolving Windows right now. |
This is currently using `my_awesome_password` which is the same example used in the users resource. This was made by running `mkpasswd -m sha-512` on a linux system. Signed-off-by: Lance Albertson <[email protected]>
There seems to be an issue with the users cookbook on Windows that needs to be addressed. Comment this test out for now until it can be fixed. Signed-off-by: Lance Albertson <[email protected]>
|
@tas50 @lamont-granquist I believe this works around the issue. I'm still trying to figure out why it's broken on windows, so I commented that code out for now. I'll re-enable it once I figure out a fix and properly test Windows on the users cookbook. The current failures are due to docker/dokken. FWIW here's the start on the fix for Windows: sous-chefs/users#448 |
|
oh that's not dokken that's the usual appbundle-updater junk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of data bags in the users cookbook was removed in 6.0.0 [1]. This applies the recommended workaround and allow the integration tests to pass.
[1] https://github.com/sous-chefs/users/blob/master/CHANGELOG.md#600---2021-03-12
Signed-off-by: Lance Albertson [email protected]