Automated PR: Cookstyle Changes #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues found and resolved with: recipes/_hosts.rb - 8:21 convention: Migration/DepartmentName - Department name is missing. - 25:20 convention: Migration/DepartmentName - Department name is missing. Issues found and resolved with: resources/shared_network.rb - 25:1 refactor: ChefModernize/DslIncludeInResource - Chef Infra Client 12.4+ includes the Chef::DSL::Recipe in the resource and provider classed by default so there is no need to include this DSL in your resources or providers. Issues found and resolved with: resources/subnet.rb - 33:1 refactor: ChefModernize/DslIncludeInResource - Chef Infra Client 12.4+ includes the Chef::DSL::Recipe in the resource and provider classed by default so there is no need to include this DSL in your resources or providers.
Generated by 🚫 Danger |
|
@bmhughes I will leave you to decide if you want this one or not? If not please close and delete the branch after your other work is merged (This will otherwise be re-created daily) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the results of a
cookstyle -aon the repo, this repo has been identified as a cookbook repo by topics of chef-cookbookChanges
Cookstyle Fixes
Issues found and resolved with recipes/_hosts.rb
Migration/DepartmentName- Department name is missing.Migration/DepartmentName- Department name is missing.Issues found and resolved with resources/shared_network.rb
ChefModernize/DslIncludeInResource- Chef Infra Client 12.4+ includes the Chef::DSL::Recipe in the resource and provider classed by default so there is no need to include this DSL in your resources or providers.Issues found and resolved with resources/subnet.rb
ChefModernize/DslIncludeInResource- Chef Infra Client 12.4+ includes the Chef::DSL::Recipe in the resource and provider classed by default so there is no need to include this DSL in your resources or providers.