Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0.0 remodel as library cookbook #133

Merged
merged 34 commits into from
Apr 17, 2020
Merged

7.0.0 remodel as library cookbook #133

merged 34 commits into from
Apr 17, 2020

Conversation

bmhughes
Copy link
Contributor

@bmhughes bmhughes commented Apr 7, 2020 •
edited
Loading

Description

  • Remodel/rewrite of the cookbook to a resource library with the removal of attributes, recipes, and legacy chef-isms.
  • Add support for DHCPv6
  • Make the resources more flexible
    • Templates can be overridden
    • Configuration options are less hard-defined

Issues Resolved

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@bmhughes bmhughes added the Waiting on Contributor Awaiting on the person who raised this to update label Apr 7, 2020
@bmhughes bmhughes requested a review from a team April 7, 2020 16:55
@kitchen-porter
Copy link
Contributor

kitchen-porter commented Apr 7, 2020 •
edited
Loading

2 Warnings
⚠️ This is a big Pull Request.
⚠️ This is a Table Flip.

Generated by 🚫 Danger

@bmhughes
Copy link
Contributor Author

bmhughes commented Apr 7, 2020

I'm still working on this at the minute, just wanted to see how far off I was to getting a CI pass.

Documentation is still to do and some review/tidying as well.

@xorima xorima added Feature Request Enhancement to existing functionality or new functionality Tech Debt Will improve the maintainability of the codebase labels Apr 7, 2020
@xorima xorima changed the title 7.0.0 remodel as library cookbook [WIP] - 7.0.0 remodel as library cookbook Apr 7, 2020
@bmhughes bmhughes removed the Waiting on Contributor Awaiting on the person who raised this to update label Apr 11, 2020
@bmhughes bmhughes changed the title [WIP] - 7.0.0 remodel as library cookbook 7.0.0 remodel as library cookbook Apr 12, 2020
@bmhughes bmhughes mentioned this pull request Apr 13, 2020
Closed
@xorima
Copy link
Contributor

xorima commented Apr 13, 2020

Let me know when you are ready for a review @bmhughes

@bmhughes
Copy link
Contributor Author

bmhughes commented Apr 13, 2020 •
edited
Loading

Fire away, the CircleCI stuff is sorted now so it's tested with DHCPv6 as well now.

ramereth
ramereth requested changes Apr 13, 2020
View reviewed changes
documentation/dhcp_group.md Outdated Show resolved Hide resolved
kitchen.dokken.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@xorima xorima added Priority: High Critical work that must be completed Table Flip This is a large scale change with fundamental usability changes labels Apr 13, 2020
@bmhughes bmhughes requested review from ramereth and xorima April 13, 2020 20:25
bmhughes added 6 commits April 14, 2020 19:38
@bmhughes
Version bump to 7.0.0
3a6683d
@bmhughes
Add vendor-option-space and options to class resource
35bb024 
1. Extended dhcp_class resource to accept options if they are specified.
2. Extended dhcp_class resource to accept vendor-option-space if it is specified.
@bmhughes
Only support Chef >= 14 from now
fa2d488
@bmhughes
Reorganise templates
55d21d1
@bmhughes
Remove attributes and recipes
6e9ce10 
1. Attributes ported to helper methods where relevant.
2. _config recipe ported to dhcp_config resource.
3. _package recipe ported to dhcp_package resource.
4. _service recipe ports to dhcp_service resource.
5. Attributes and recipes removed.
@bmhughes
Config and subnet resources with support for DHCP and DHCPv6
dfaf743
bmhughes added 17 commits April 15, 2020 11:15
@bmhughes
All options and parameters properties accept Hash or Array
722987a
@bmhughes
Documentation updated for new resources
c084b0a
@bmhughes
Kitchen test with disabled and deleted configurations
28d555e
@bmhughes
Expand kitchen platforms
c5bc2ba
@bmhughes
Add support for configuring unit environment file
1daa028
@bmhughes
Switch IPv6 detection due to inspec bug with older iproute versions
26f6c74
@bmhughes
Kitchen testing with IPv6 on CircleCI
d1ca412
@bmhughes
Kitchen test with latest Chef version
cc70985
@bmhughes
Add UPGRADING guide and extend documentation
835fb6e
@bmhughes
Fix bug in property sorting with more than one value
42faea7
@bmhughes
Alter wording of subnet pool verification error messages
5a07523
@bmhughes
Documentation corrections
a97ec9a
@bmhughes
Remove sort from evals
a714806
@bmhughes
Amend failover configuration file template for explicit role definition
963502a
@bmhughes
Split property helper into a sorted and unsorted varient
359047c 
Annoyingly, the ordering of configuration statements is important
in some contexts, for example when configuring an option space it is
critical that the space is defined before an option.
@bmhughes
Make subnet property optional on dhcp_subnet
83d28db
@bmhughes
Change dhcp_group to use nested host resources and group testing
1bf3f40
@xorima xorima requested a review from ramereth April 16, 2020 19:20
ramereth
ramereth previously approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AFAIK!

@bmhughes bmhughes merged commit 920d1c7 into sous-chefs:master Apr 17, 2020
@bmhughes bmhughes deleted the v7-remodel-as-library branch April 17, 2020 14:55
@xorima
Copy link
Contributor

xorima commented Apr 17, 2020

🥳

This was referenced Apr 20, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xorima xorima xorima approved these changes

@ramereth ramereth ramereth left review comments

@tas50 tas50 Awaiting requested review from tas50

@damacus damacus Awaiting requested review from damacus

@JohnRoesler JohnRoesler Awaiting requested review from JohnRoesler

Assignees

@bmhughes bmhughes

Labels
Feature Request Enhancement to existing functionality or new functionality Priority: High Critical work that must be completed Table Flip This is a large scale change with fundamental usability changes Tech Debt Will improve the maintainability of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmhughes @kitchen-porter @xorima @ramereth