Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 3.8 and 3.9, default to 3.10 for most CI tasks #2848

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

luizirber
Copy link
Member

Numpy NEP 29 is now Scientific Python SPEC 0, and according to that we could drop 3.9 already. We still had many places mentioning 3.8 (and even 3.7!), so I went through all mentions to 3.7/37/3.8/38/3.9/39 and removed them, updating to 3.10 (our new lowest supported Python version) as appropriate.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30aa79d) 86.25% compared to head (705a50f) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2848      +/-   ##
==========================================
- Coverage   86.25%   86.23%   -0.03%     
==========================================
  Files         130      130              
  Lines       14752    14752              
  Branches     2623     2617       -6     
==========================================
- Hits        12725    12722       -3     
- Misses       1726     1730       +4     
+ Partials      301      300       -1     
Flag Coverage Δ
hypothesis-py 25.81% <ø> (ø)
python 92.83% <ø> (-0.03%) ⬇️
rust 50.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luizirber luizirber requested a review from a team November 23, 2023 03:58
@luizirber
Copy link
Member Author

luizirber commented Nov 23, 2023

TODO:

Copy link
Contributor

@ctb ctb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@luizirber luizirber merged commit 32d46dd into latest Nov 25, 2023
33 of 34 checks passed
@luizirber luizirber deleted the lirber/drop_38_39 branch November 25, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants