-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add --from-file
option to sourmash sketch
commands
#1362
Conversation
Ready for review @bluegenes! |
Codecov Report
@@ Coverage Diff @@
## latest #1362 +/- ##
==========================================
+ Coverage 88.80% 94.13% +5.33%
==========================================
Files 123 96 -27
Lines 18207 14650 -3557
Branches 1405 1409 +4
==========================================
- Hits 16169 13791 -2378
+ Misses 1800 621 -1179
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sigdata = fp.read() | ||
siglist = list(signature.load_signatures(sigdata)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reasoning behind using this syntax vs load_file_as_signatures
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hah! no, not really, I just wrote these tests before load_file_as_signatures
was available, and since it's internal test code I'm not as worried about using the public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! file lists are so handy
This PR adds
sourmash sketch dna|protein|translate --from-file list_of_files.txt
.Per @klamens request here, #1338 (comment)
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?