Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename load_file_list_of_signatures in sourmash_args.py #1369

Closed
ctb opened this issue Mar 6, 2021 · 0 comments · Fixed by #1423
Closed

rename load_file_list_of_signatures in sourmash_args.py #1369

ctb opened this issue Mar 6, 2021 · 0 comments · Fixed by #1423
Labels
good first issue python Pull requests that update Python code

Comments

@ctb
Copy link
Contributor

ctb commented Mar 6, 2021

The function load_file_list_of_signatures in src/sourmash/sourmash_args.py was initially used only for loading a text file that contained a list of signature filenames, but since has changed (e.g. #1362) to support lists of FASTA files.

TODO:

  • rename the function to load_pathlist_from_file (or a better name if you have one :)
  • find all places where the old name is used in the code base, perhaps with git grep -l load_file_list_of_signatures and rename it there
  • optionally, add some Python unit tests in tests/test_sourmash.py for this function, including empty file list, badly formatted ones, ones with duplicates, ???
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant