Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

bazel: build the //lib folder #46929

Merged
merged 17 commits into from
Jan 27, 2023
Merged

bazel: build the //lib folder #46929

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9065ab0
Fix sg/scip dep build
jhchabran Jan 24, 2023
420235b
Update buildfiles
jhchabran Jan 24, 2023
3603c94
fixup
jhchabran Jan 24, 2023
0ccfedd
Fix a dependency issue with resources-report
jhchabran Jan 24, 2023
d0dae65
Bump buildfiles
jhchabran Jan 24, 2023
d2fb85f
bzl: build //lib/...
jhchabran Jan 24, 2023
96c4ac4
revert some dumb stuff
jhchabran Jan 24, 2023
aa80bec
Fix sg generate
jhchabran Jan 25, 2023
4637019
fixup up
jhchabran Jan 25, 2023
de8354b
Update resources-report deps
jhchabran Jan 25, 2023
87c5413
Remove leftover
jhchabran Jan 25, 2023
9c247bf
fixup
jhchabran Jan 25, 2023
f51bf2f
Merge remote-tracking branch 'origin/main' into bzl/go/lib
jhchabran Jan 26, 2023
aa85b5a
update
jhchabran Jan 26, 2023
68836ef
fix tab
jhchabran Jan 26, 2023
bd6c472
Merge remote-tracking branch 'origin/main' into bzl/go/lib
jhchabran Jan 27, 2023
525711f
Update build files
jhchabran Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .bazelignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ client/plugin-backstage/node_modules

cmd/symbols/squirrel/test_repos/starlark
docker-images/syntax-highlighter/crates/sg-syntax/src/snapshots/

lib/codeintel/precise/diff/testdata/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can get picked up by gazelle and will incorectly generate buildfiles.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use a glob? Likely this isn't the only place we have go code that lives under testdata dir. Go compiler always ignores it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keegancsmith we cannot sadly, see bazelbuild/bazel#7093

Loading