bazel: build the //lib folder #46929
Conversation
| @@ -26,3 +26,5 @@ client/plugin-backstage/node_modules | |||
|
|
|||
| cmd/symbols/squirrel/test_repos/starlark | |||
| docker-images/syntax-highlighter/crates/sg-syntax/src/snapshots/ | |||
|
|
|||
| lib/codeintel/precise/diff/testdata/ | |||
There was a problem hiding this comment.
This can get picked up by gazelle and will incorectly generate buildfiles.
There was a problem hiding this comment.
can you use a glob? Likely this isn't the only place we have go code that lives under testdata dir. Go compiler always ignores it.
There was a problem hiding this comment.
@keegancsmith we cannot sadly, see bazelbuild/bazel#7093
|
Not notifying subscribers because the number of notifying subscribers (15) has exceeded the threshold (10). |
|
Codenotify: Notifying subscribers in OWNERS files for diff 728ea45...525711f.
|
| build_directives = [ | ||
| "gazelle:resolve go github.com/sourcegraph/sourcegraph/lib/errors @//lib/errors", | ||
| "gazelle:resolve go github.com/sourcegraph/sourcegraph/lib/codeintel/lsif/protocol @//lib/codeintel/lsif/protocol", | ||
| "gazelle:resolve go github.com/sourcegraph/sourcegraph/lib/codeintel/lsif/protocol/reader @//lib/codeintel/lsif/protocol/reader", | ||
| "gazelle:resolve go github.com/sourcegraph/sourcegraph/lib/codeintel/lsif/protocol/writer @//lib/codeintel/lsif/protocol/writer", | ||
| ], |
There was a problem hiding this comment.
This effectively does the same thing as having the replace directive.
|
Not notifying subscribers because the number of notifying subscribers (15) has exceeded the threshold (10). |
|
Not notifying subscribers because the number of notifying subscribers (15) has exceeded the threshold (10). |
|
Not notifying subscribers because the number of notifying subscribers (15) has exceeded the threshold (10). |
This PR adds a bunch of fixes to be able to build
//lib/....@jbedard if you stumble across this PR, and to follow up with our conversation from yesterday, I'm adding things in separate jobs here only as a temporary measure, so I can track that I'm not breaking things as I progress through the migration. This is obviously not the final approach, which is to simply
build //...The notable fix that this PR includes is to add some build directives to the
sourcegraph/scipgo_repositoryrule, in order to deal with the fact that we're using areplacedirective in our rootgo.modto work around the circular depedency (sourcegraph/scip depends on sourcegraph/sourcegraph/lib which then also depends on sourcegraph/scip).@bobheadxi I had to update
internal/cmd/resources-reportalong the way. There are no unit tests, so apart for building it, so I couldn't really QA it further.Fixes #46832
Test plan
I ran a main-dry-run over https://buildkite.com/sourcegraph/sourcegraph/builds/195371 to ensure merging this does not break anything.