Chat: brought back syntax highlighting for most common languages #5953
+125
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as dart or scss - Updated rehype-highlight to ^7.0.0 in orde to get rid of lowlight 2.9.0 and load only version 3.1.0 - Added dependency on highlight.js since we load these extra syntax languages and tslint complains if we don't add it
- As requested in review as it seems there were performance issues with rehype-highlight 7.0.0 as seen in pull request #5313
… languages from highligh.js - This way we can trim the bundle even more by importing only languages that should be supported
|
@dominiccooney my original pull request can also run tests as long as someone approves the latest commit Pending test running approval, I would rather have my pull request only where I've written a few comments where I've asked for input which I am still waiting for rather than having this copy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored by @ichim-david in #5874. This branch created to run CI.
Test plan
Ask chat to provide an example program for dart language.
You should now see the dart snippets having syntax highlighting which started missing after
the work done in this pull request:
#5232
Example screenshot with the fix in action:
Changelog
Chat: brought back syntax highlighting for most common languages