Revert: rehype-highlight bump #5313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@sqs By popular vote users prefer to avoid OOM causing grey-screens over saving 300 kb on bundle size 🧌 😅 All joking aside, if this was the cause again I'll invest some time in figuring out how we can do some better benchmarking / profiling as part of the test suite. |
umpox
approved these changes
Aug 23, 2024
umpox
pushed a commit
that referenced
this pull request
Aug 23, 2024
There has been a (long ongoing) issue with `rehype-highlight` / `highight-js` causing OOM issues on `>v6.0.0`. This reverts a recent version bump that might have [re-introduced this issue](#4459) in Cody chat causing grey-screens and crashes. > Important: I wasn't able to re-produce the issue myself for some reason. So this is a bit of a "shot-in-the-dark" fix. Hopefully we can have those who reported the issue validate if it actually worked. Lowering the version shouldn't hurt any other changes though as it was merely done to reduce the bundle size somewhat. ## Test plan CI
ichim-david
added a commit
to ichim-david/cody
that referenced
this pull request
Oct 12, 2024
- As requested in review as it seems there were performance issues with rehype-highlight 7.0.0 as seen in pull request sourcegraph#5313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a (long ongoing) issue with
rehype-highlight/highight-jscausing OOM issues on>v6.0.0. This reverts a recent version bump that might have re-introduced this issue in Cody chat causing grey-screens and crashes.Test plan
CI