chore(package manager): introduce Corepack #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From now on, we will use Corepack to manage pnpm versions. see https://nodejs.org/api/corepack.html see https://github.com/nodejs/corepack
Corepack automatically prepares the pnpm. Thus, all we have to do is execute the `corepack enable` command.
…stall -g ...` command
Surprisingly, Corepack seems to work with all versions of Node.js on GitHub Actions. Perhaps there is no need to run the `corepack enable` command.
…le` command
The following error occurred on each job:
pnpm: command not found
It seems that the `corepack enable` command must be executed.
This reverts commit 8cb0f48.
…ore understandable The step name "Setup Corepack" indicates that it is setting up Corepack. However, this step name does not clearly indicate that pnpm will be available automatically. Contributors who are not familiar with Node.js will not be able to grasp what is possible by enabling Corepack. So we fix the step names and clarify what we are enabling Corepack for.
|
Code Climate has analyzed commit f1cdfd5 and detected 0 issues on this pull request. View more on Code Climate. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on, we will use Corepack to manage pnpm versions.
see https://nodejs.org/api/corepack.html
see https://github.com/nodejs/corepack