Skip to content

Commit

Permalink
ci(github actions): fix the name of steps for enable Corepack to be m…
Browse files Browse the repository at this point in the history
…ore understandable

The step name "Setup Corepack" indicates that it is setting up Corepack.
However, this step name does not clearly indicate that pnpm will be available automatically.
Contributors who are not familiar with Node.js will not be able to grasp what is possible by enabling Corepack.
So we fix the step names and clarify what we are enabling Corepack for.
  • Loading branch information
sounisi5011 committed Feb 26, 2023
1 parent dac033c commit f1cdfd5
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -73,7 +73,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Setup Corepack
- name: Enable Corepack (Automatically setup a package manager for Node.js)
run: corepack enable
- name: Cache .pnpm-store
uses: actions/cache@v3
@@ -145,7 +145,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Setup Corepack
- name: Enable Corepack (Automatically setup a package manager for Node.js)
run: corepack enable
- name: Cache actionlint
uses: actions/cache@v3
@@ -184,7 +184,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Setup Corepack
- name: Enable Corepack (Automatically setup a package manager for Node.js)
run: corepack enable
- name: Setup dprint
# The dprint command may fail to deserialize the wasm module.
@@ -303,7 +303,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Setup Corepack
- name: Enable Corepack (Automatically setup a package manager for Node.js)
run: corepack enable
- name: Install flatbuffers
# https://snapcraft.io/flatbuffers
@@ -445,7 +445,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Setup Corepack
- name: Enable Corepack (Automatically setup a package manager for Node.js)
shell: bash
# If Corepack does not exist or a Corepack version range is specified, install Corepack
run: |
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -124,7 +124,7 @@ jobs:
with:
node-version: 16.x
if: ${{ steps.release-pr.outputs.ref }}
- name: Commit to Release PR / Setup Corepack
- name: Commit to Release PR / Enable Corepack (Automatically setup a package manager for Node.js)
run: corepack enable
if: ${{ steps.release-pr.outputs.ref }}
- name: Commit to Release PR / Cache .pnpm-store
@@ -215,7 +215,7 @@ jobs:
# Note: The `registry-url` option is required.
# If this option is not set, the "npm publish" command will not detect the environment variable NODE_AUTH_TOKEN.
if: ${{ steps.release.outputs.releases_created }}
- name: Publish / Setup Corepack
- name: Publish / Enable Corepack (Automatically setup a package manager for Node.js)
run: corepack enable
if: ${{ steps.release.outputs.releases_created }}
- name: Publish / Cache .pnpm-store

0 comments on commit f1cdfd5

Please sign in to comment.