Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency eslint-plugin-import to v2.18.0 #36

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jun 24, 2019

This PR contains the following updates:

Package Type Update Change
eslint-plugin-import devDependencies minor 2.17.3 -> 2.18.0

Release Notes

benmosher/eslint-plugin-import

v2.18.0

Compare Source

Added
  • Support eslint v6 ([#​1393], thanks [@​sheepsteak])
  • [order]: Adds support for correctly sorting unknown types into a single group ([#​1375], thanks [@​swernerx])
  • [order]: add fixer for destructuring commonjs import ([#​1372], thanks [@​golopot])
  • typescript config: add TS def extensions + defer to TS over JS ([#​1366], thanks [@​benmosher])
Fixes
  • [no-unused-modules]: handle ClassDeclaration ([#​1371], thanks [@​golopot])
Docs
  • [no-cycle]: split code examples so file separation is obvious ([#​1370], thanks [@​alex-page])
  • [no-named-as-default-member]: update broken link ([#​1389], thanks [@​fooloomanzoo])

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot force-pushed the renovate/eslint-plugin-import-2.x branch from 0b4b98c to fd204e9 Compare June 25, 2019 01:33
@renovate renovate bot force-pushed the renovate/eslint-plugin-import-2.x branch from fd204e9 to 7a862a3 Compare June 25, 2019 02:26
@sounisi5011
Copy link
Owner

This package has been added to use eslint-config-standard: be178fd
I need to consider the compatibility with eslint-config-standard.

@sounisi5011
Copy link
Owner

This update supports TypeScript type definition files: import-js/eslint-plugin-import#1366

Therefore, I think that I can omit the extra setting needed to make ESLint work correctly.

import/resolver:
node:
extensions:
- .js
- .d.ts
moduleDirectory:
- node_modules/@types
- node_modules

@renovate
Copy link
Author

renovate bot commented Jun 25, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@sounisi5011
Copy link
Owner

This update supports TypeScript type definition files: benmosher/eslint-plugin-import#1366

Therefore, I think that I can omit the extra setting needed to make ESLint work correctly.

import/resolver:
node:
extensions:
- .js
- .d.ts
moduleDirectory:
- node_modules/@types
- node_modules

It seems that this setting was unnecessary from the beginning.
I tried with the previous eslint-plugin-import, but it seems to work with or without this setting.

Copy link
Owner

@sounisi5011 sounisi5011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran ESLint but it passed.
I do not think that this update will have any adverse effects.

@sounisi5011 sounisi5011 merged commit b1079fd into master Jun 25, 2019
@sounisi5011 sounisi5011 deleted the renovate/eslint-plugin-import-2.x branch June 25, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants