feat: support import ts definition #1366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
ljharb
reviewed
May 28, 2019
| @@ -2,7 +2,7 @@ | |||
| * Adds `.jsx`, `.ts` and `.tsx` as an extension, and enables JSX/TSX parsing. | |||
| */ | |||
| var jsExtensions = ['.js', '.jsx']; | |||
| var tsExtensions = ['.ts', '.tsx']; | |||
| var tsExtensions = ['.d.ts','.ts', '.tsx']; | |||
There was a problem hiding this comment.
i'm concerned this might be a breaking change.
There was a problem hiding this comment.
This should be:
var tsExtensions = ['.ts', '.d.ts', '.tsx'];
There was a problem hiding this comment.
I think it should be ['.ts', '.tsx', '.d.ts'], no? A full React module should override a definition file, I would think?
In practice I would expect it to matter <<0.1% of the time, though. Seems like a weird case to have definitions and full TS modules at the same filename location. Whereas a .d.ts should override a .js file, right?
So maybe the correct thing would be
var allExtensions = ['.ts', '.tsx', '.d.ts', '.js', '.jsx'];
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript support extension with .d.ts
But in current config of
import, it should complain error when try import custom type.