Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add some missing attributes to loader tests #2262

Merged
merged 1 commit into from
Mar 10, 2022
Merged

test: add some missing attributes to loader tests #2262

merged 1 commit into from
Mar 10, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Feb 28, 2022

Description

Tin. We weren't checking the presence/absence of echo or allow_bots attrs or verifying that the correct default values are set for them. Also noticed a clean_callable test with no idempotency check.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches
    • They're literally tests. 😏

@dgw
test: add some missing attributes to loader tests
ccc0968 
We weren't checking the presence/absence of `echo` or `allow_bots` attrs
or verifying that the correct default values are set for them.

Also noticed a `clean_callable` test with no idempotency check.
@dgw dgw added Tests Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Feb 28, 2022
@dgw dgw added this to the 8.0.0 milestone Feb 28, 2022
@dgw dgw requested a review from a team February 28, 2022 02:05
@Exirel
Copy link
Contributor

Exirel commented Feb 28, 2022

We weren't checking the presence/absence of echo or allow_bots attrs or verifying that the correct default values are set for them.

I can't remember adding these flags anyway. 💪 😎

Exirel
Exirel approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@dgw
Copy link
Member Author

dgw commented Feb 28, 2022

I can't remember adding these flags anyway. 💪 😎

You didn't write them; I did. 😁 (#1470, #2244)

@dgw dgw merged commit 4a72004 into master Mar 10, 2022
@dgw dgw deleted the test-loader-better branch March 10, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc. Tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel