loader, plugin, plugins.rules: add allow_bots decorator
#2244
Conversation
dgw
force-pushed
the
plugin.allow_bots
branch
from
61544fc to
2f27ab4
Compare
|
Is there a section of the documentation about non-rule decorators, such as echo and now allow_bot? If so, it should be updated. Otherwise, it means a future PR will be needed to talk about that. |
|
Do you mean a section on the And of course the decorators themselves are autodoc'd at |
Great! And yes, I was thinking about that, so that would be perfect thank you. ❤️ |
|
I took a stab at the documentation update. My IRC client is currently closed because my ongoing network problems are so distracting. I might stick to GitHub comments for a while, just for my own sanity's sake. |
|
Happy to get a second look before I squash, @Exirel. I almost committed a nemesiS of my own. 😁 |
|
Let's. Go. 🚢 |
Noted some gaps in the test suite regarding the loader setting defaults for certain callable attributes (including this new one), but elected to leave that for a future patch.
These didn't get any brief mention on the "Anatomy of a plugin" page, like most of their siblings already had. It seemed only fair. Also added a gotcha to the `echo` decorator's docs.
dgw
force-pushed
the
plugin.allow_bots
branch
from
526bf73 to
834f546
Compare
Description
You know, it's fun when you find an unmerged branch hanging around during a local cleanup.
It needs rebasing, which I'll handle in a moment, but it will fill a gap in the plugin decorator library. After #2089 we're missing a way for plugin authors to opt back into getting messages from other bots. Most will probably appreciate the filtering Sopel now does on their behalf, but I'm sure there are a few who relied on the old behavior…
Checklist
make qa(runsmake qualityandmake test)I will make sure of this after rebasing.It was true! And I even remembered to upgrade the dev-reqs before running tests.