Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve if op #1038

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Improve if op #1038

merged 2 commits into from
Apr 25, 2023

Conversation

kali
Copy link
Collaborator

@kali kali commented Apr 10, 2023

ONNX If only works has a loading macro expansion: the condition must be known and fixed at loading time, the right branch is substituted in the type phase. This blocks Silero VAD v4 (see #1029).

  • make analyse work when input is dynamic
  • implement an If operator in core and translate ONNX op into it
  • find out how to encode this in NNEF
  • into_optimized as in Scan
  • declutter as in Scan

@kali kali mentioned this pull request Apr 25, 2023
5 tasks
@kali
Copy link
Collaborator Author

kali commented Apr 25, 2023

Moving mid-term tracking to #1062. This PR is merged to land in 0.20 with partial support (analysis and basic core support).

@kali kali merged commit df74df8 into main Apr 25, 2023
@kali kali deleted the improve-if-op branch August 10, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant