make analyse work in the dynamic case

sonos · Apr 10, 2023 · 528afb4 · 528afb4
1 parent 7e98f1b
commit 528afb4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/hir/src/infer/model.rs b/hir/src/infer/model.rs
@@ -120,8 +120,7 @@ impl InferenceModelExt for InferenceModel {
                 } else {
                     let outputs = node
                         .op
-                        .to_typed(source, node, target, mapping)
-                        .with_context(|| format!("translating op {:?}", node.op))?;
+                        .to_typed(source, node, target, mapping)?;
                     for output in &outputs {
                         let fact = target.outlet_fact(*output)?;
                         fact.consistent().with_context(|| {

diff --git a/onnx/src/ops/logic.rs b/onnx/src/ops/logic.rs
@@ -120,6 +120,12 @@ impl InferenceOp for If {
                     changed =
                         changed || body.output_fact_mut(oix)?.unify_with_mut(&mut outputs[oix])?;
                 }
+            } else {
+                for ix in 0..self.nboutputs()? {
+                    changed = changed
+                        || self.then_body.output_fact_mut(ix)?.unify_with_mut(&mut outputs[ix])?
+                        || self.else_body.output_fact_mut(ix)?.unify_with_mut(&mut outputs[ix])?;
+                }
             }
             changed = changed || self.then_body.analyse(false)?;
             changed = changed || self.else_body.analyse(false)?;