Remove dependency on click-default-group package #903
Merged
+98
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
May 5, 2020
pavel-shirshov
approved these changes
May 9, 2020
This was referenced Jun 18, 2020
jleveque
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 19, 2020
All dependencies upon the Python 'click-default-group' package have been removed from sonic-utilities as of sonic-net/sonic-utilities#903. The submodule was updated to include this patch as of #4601, therefore we no longer need to install this package in the SONiC image.
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Reverted Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) as it dependent of sonic-net#903 which is not marked to cherry-pick for 201911. Need to add that before we can use this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inheriting
DefaultGroupclass from click-default-group package breaks autocomplete, so we remove dependence upon it.Fixes #27
In doing so, a couple commands changed:
Previously,
sonic-clear ip bgpwould, by default, clear all bgp data for all neighbors. This functionality was already being duplicated if someone ransonic-clear ip bgp neighborwithout specifying a peer IP address. Thus, I instead added an 'all' subcommand tosonic-clear ip bgp neighbor(and also added a matching 'all' subcommand to the 'soft' groupsonic-clear ip bgp soft), restructuring thesonic-clear ip bgpcommands as follows:sonic-clear ip bgp neighbor all [<ipaddress>]sonic-clear ip bgp neighbor in [<ipaddress>]sonic-clear ip bgp neighbor out [<ipaddress>]sonic-clear ip bgp neighbor soft all [<ipaddress>]sonic-clear ip bgp neighbor soft in [<ipaddress>]sonic-clear ip bgp neighbor soft out [<ipaddress>]I think we could further consolidate these functions in the future by adding
softas an option (e.g., a-s|--softflag?) to the first threesonic-clear ip bgp neighborcommands instead of making it its own subgroup of commands (opened issue [clear] Consolidate 'soft' variants of bgp neighbor clear commands #906).I also think we should consider removing the
undebugutility, and instead add anon|offparameter to all commands in thedebugutility, thus consolidating further (opened issue Consider removing 'undebug' utility and consolidate functinality into 'debug' utility #905).Also corrected some docstrings