Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clear] Consolidate 'soft' variants of bgp neighbor clear commands #906

Open
jleveque opened this issue May 5, 2020 · 0 comments
Open

[clear] Consolidate 'soft' variants of bgp neighbor clear commands #906

jleveque opened this issue May 5, 2020 · 0 comments
Labels
Cleanup 💧 Help Wanted

Comments

@jleveque
Copy link
Contributor

jleveque commented May 5, 2020

We should consider consolidating subcommands in sonic-clear. Currenty we have the following bgp subcommands:

sonic-clear ip bgp neighbor all [<ipaddress>]
sonic-clear ip bgp neighbor in [<ipaddress>]
sonic-clear ip bgp neighbor out [<ipaddress>]
sonic-clear ip bgp neighbor soft all [<ipaddress>]
sonic-clear ip bgp neighbor soft in [<ipaddress>]
sonic-clear ip bgp neighbor soft out [<ipaddress>]

We could consolidate these functions by adding soft as an option (e.g., a -s|--soft flag?) to the first three clear ip bgp neighbor commands, leaving us with the following:

sonic-clear ip bgp neighbor all [<ipaddress>] [-s|--soft]
sonic-clear ip bgp neighbor in [<ipaddress>] [-s|--soft]
sonic-clear ip bgp neighbor out [<ipaddress>] [-s|--soft]
@jleveque jleveque mentioned this issue May 5, 2020
Merged
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this issue Apr 18, 2022
@tjchadaga
[202012] sairedis submodule update (#9156)
cc3e595 
These changes are included in this PR:

07e1f79 [syncd] Add workaround for warm boot new objects (sonic-net#959)
50fd353 Fix the option missing in kernel config issue (sonic-net#956)
e77503c [syncd] Comparison logic workaround for empty buffer profile (sonic-net#906) (sonic-net#941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup 💧 Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jleveque