-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip default lanes dup check #3489
Merged
judyjoseph
merged 5 commits into
sonic-net:master
from
xincunli-sonic:xincun/skip-default-lanes-dup-check
Aug 16, 2024
Merged
Skip default lanes dup check #3489
judyjoseph
merged 5 commits into
sonic-net:master
from
xincunli-sonic:xincun/skip-default-lanes-dup-check
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen587
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
abdosi
approved these changes
Aug 15, 2024
judyjoseph
approved these changes
Aug 16, 2024
@judyjoseph Is this needed for 202405? |
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 6, 2024
* Add namespace check for multiasic * Skip Default lane duplication check.
Cherry-pick PR to 202405: #3533 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Add namespace check for multiasic * Skip Default lane duplication check.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sep 6, 2024
BYGX-wcr
added
the
included in chassis for 202205 branch
indicate that this PR got merged into the "chassis for 202205 branch"
label
Sep 11, 2024
xincunli-sonic
added a commit
that referenced
this pull request
Oct 10, 2024
This reverts commit 1c4300f.
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 22, 2024
Reverts #3489 since the PR: sonic-net/sonic-buildimage#19968 has merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved for 202405 Branch
Chassis for 202205 Branch
included in chassis for 202205 branch
indicate that this PR got merged into the "chassis for 202205 branch"
Included in 202405 Branch
Request for 202405 Branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Skip default lanes dup check.
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)