-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chassis] add condition is yang model to make lanes not mandatory for chassis #19968
[chassis] add condition is yang model to make lanes not mandatory for chassis #19968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi @arlakshm , could you check the failure of checker? |
I confirmed that this PR fixes the failures seen in sonic-net/sonic-mgmt#14583 for Arista. |
/azpw ms_conflict |
/azpw ms_conflict |
Hi @qiluo-msft , can you help merge this one? |
… chassis (sonic-net#19968) ### Why I did it In the sonic chassis the port table on the host does not lanes. Add conditions in the lab chassis to make lanes not mandatory for chassis devices ### How I did it Add the check in `sonic-port.yang` to make lanes are mandatory in the host config_db only for non-chassis devices. #### How to verify it UT.
Reverts #3489 since the PR: sonic-net/sonic-buildimage#19968 has merged.
Why I did it
In the sonic chassis the port table on the host does not lanes. Add conditions in the lab chassis to make lanes not mandatory for chassis devices
Work item tracking
How I did it
Add the check in
sonic-port.yang
to make lanes are mandatory in the host config_db only for non-chassis devices.How to verify it
UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)