Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify "show interface transceiver status" CLI to show SW cmis state #3238

Merged
merged 1 commit into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/mock_tables/state_db.json
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@
"rx_sig_power_max": "40"
},
"TRANSCEIVER_STATUS|Ethernet44":{
"cmis_state": "READY",
"DP1State": "DataPathActivated",
"DP2State": "DataPathActivated",
"DP3State": "DataPathActivated",
Expand Down
1 change: 1 addition & 0 deletions tests/sfp_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@

test_qsfp_dd_status_output = """\
Ethernet44:
CMIS State (SW): READY
Tx fault flag on media lane 1: False
Tx fault flag on media lane 2: False
Tx fault flag on media lane 3: False
Expand Down
1 change: 1 addition & 0 deletions utilities_common/sfp_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
# For non-CMIS, only first 1 or 4 lanes are applicable.
# For CMIS, all 8 lanes are applicable.
QSFP_STATUS_MAP = {
'cmis_state': 'CMIS State (SW)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihirpat1 thanks for adding explicit SW

'txfault1': 'Tx fault flag on media lane 1',
'txfault2': 'Tx fault flag on media lane 2',
'txfault3': 'Tx fault flag on media lane 3',
Expand Down
Loading