-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify "show interface transceiver status" CLI to show SW cmis state #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Mar 23, 2024
@@ -47,6 +47,7 @@ | |||
# For non-CMIS, only first 1 or 4 lanes are applicable. | |||
# For CMIS, all 8 lanes are applicable. | |||
QSFP_STATUS_MAP = { | |||
'cmis_state': 'CMIS State (SW)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihirpat1 thanks for adding explicit SW
prgeor
approved these changes
Mar 23, 2024
@StormLiangMS @yxieca - Can you please help in merging this to 202305 and 202311? |
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Mar 26, 2024
…onic-net#3238) Signed-off-by: Mihir Patel <[email protected]>
Cherry-pick PR to 202311: #3245 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 26, 2024
…3238) Signed-off-by: Mihir Patel <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Mar 26, 2024
arfeigin
pushed a commit
to arfeigin/sonic-utilities
that referenced
this pull request
Apr 2, 2024
…onic-net#3238) Signed-off-by: Mihir Patel <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Apr 3, 2024
…onic-net#3238) Signed-off-by: Mihir Patel <[email protected]>
Cherry-pick PR to 202305: #3258 |
mssonicbld
pushed a commit
that referenced
this pull request
Apr 3, 2024
…3238) Signed-off-by: Mihir Patel <[email protected]>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
With the below PR, we are now storing
cmis_state
inTRANSCEIVER_STATUS
table ofSTATE_DB
. Hence, we need to modify theshow interface transceiver status
CLI to show the softwarecmis_state
of a portsonic-net/sonic-platform-daemons#449
MSFT ADO - 27254777
How I did it
Added
cmis_state
inQSFP_STATUS_MAP
to display it for all types of transceivers which have this field populated.How to verify it
show int transceiver status
with thecmis_state
field present in TRANSCEIVER_STATUS tableshow int transceiver status
with thecmis_state
field absent in TRANSCEIVER_STATUS tablePrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)