[config/show] add support for vlan configuration #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
both swsssdk PR has been merge, can you help to resolve the conflict? |
|
@lguohan done. |
yxieca
reviewed
Dec 5, 2017
config/main.py
Outdated
| @click.pass_context | ||
| def del_vlan(ctx, vid): | ||
| db = ctx.obj['db'] | ||
| db.set_entry('VLAN', 'Vlan{}'.format(vid), None) |
There was a problem hiding this comment.
Would it be better to delete vlan members before deleting the vlan itself?
There was a problem hiding this comment.
Thanks for your review. fixed.
$ config vlan add 1000
$ config vlan member add 1000 Ethernet1
$ config vlan member add 1000 Ethernet9_1 -u
$ config vlan add 2000
$ config vlan member add 2000 Ethernet1
$ config vlan member add 2000 Ethernet9_2 -u
$ show vlan config
Name VID Member Mode
-------- ----- ----------- --------
Vlan1000 1000 Ethernet1 tagged
Ethernet9_1 untagged
Vlan2000 2000 Ethernet1 tagged
Ethernet9_2 untagged
$ config vlan member del 1000 Ethernet1
$ config vlan member del 2000 Ethernet
$ show vlan config
Name VID Member Mode
-------- ----- ----------- --------
Vlan1000 1000 Ethernet9_1 untagged
Vlan2000 2000 Ethernet9_2 untagged
$ config vlan del 1000
$ config vlan del 2000
$ show vlan config
Name VID Member Mode
------ ----- -------- ------
Signed-off-by: Wataru Ishida <[email protected]>
vdahiya12
pushed a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Jul 23, 2021
Add GitHub pull request template
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
* [sonic_y_cable] add check_mux_direction api for y_cable Summary: This PR provides the support for checking the mux_direction on the y_cable by checking the mux_direction register Approach added the changes in y_cable.py with register specification for check_mux_direction What is the motivation for this PR? check_mux_direction is required for y_cable_utilities to replace the active_linked_tor_side -> check_mux_direction as agreed as a part of design Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sonic-net/sonic-py-swsssdk#22 and sonic-net/sonic-py-swsssdk#23 need to be get merged before this PR.