Add support for snat, dnat and ipmc crm resources #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add unit tests accordingly. |
Signed-off-by: Prabhu Sreenivasan <[email protected]> Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom>
PrabhuSreenivasan
force-pushed
the
crm_ipmc_nat
branch
from
3b44b87
to
fca8737
Compare
I have updated the PR with sonic-utilities test cases for the newly added resources. |
lguohan
previously approved these changes
Nov 25, 2020
lguohan
reviewed
Nov 25, 2020
When no data on CONFIG_DB, crm show threshold CLI command will not have these resources listed.
No exception will be observed on both cases. |
|
retest this please |
|
All, @arlakshm - this has been quiet for 6 days - can we get some review input so we can move forwards please? The clock is ticking ... |
arlakshm
approved these changes
Dec 23, 2020
|
@ben-gale - fyi on a test failure which might be related to this PR - https://github.com/Azure/sonic-buildimage/issues/6302 |
arlakshm
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 29, 2020
What I did Added support for snat, dnat and ipmc resources under CRM module. Why I did it New feature NAT adds new resources snat_enty and dnat_entry that needs to be monitored. ipmc_entry tracks IP multicast resources used by switch. Associated PRs sonic-net/sonic-utilities/pull/1258 sonic-net/sonic-buildimage#6012 Signed-off-by: Prabhu Sreenivasan <[email protected]>
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
Signed-off-by: Prabhu Sreenivasan [email protected] - What I did Added support for snat, dnat and ipmc resources under CRM module. - How I did it New feature NAT adds new resources snat_enty and dnat_entry that needs to be monitored. ipmc_entry tracks IP multicast resources used by switch. - How to verify it sonic-utilities tests and crm spytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prabhu Sreenivasan [email protected]
- What I did
Added support for snat, dnat and ipmc resources under CRM module.
- How I did it
New feature NAT adds new resources snat_enty and dnat_entry that needs to be monitored. ipmc_entry tracks IP multicast resources used by switch.
- How to verify it
sonic-utilities tests and crm spytest
- Associated PRs
sonic-net/sonic-swss#1511
sonic-net/sonic-buildimage#6012
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)