Add support for snat, dnat and ipmc crm resources #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom>
lguohan
reviewed
Nov 24, 2020
| @@ -10,7 +10,7 @@ | |||
| "polling_interval": "300", | |||
| {%- for crm_res in ["ipv4_route", "ipv6_route", "ipv4_nexthop", "ipv6_nexthop", "ipv4_neighbor", | |||
| "ipv6_neighbor", "nexthop_group_member", "nexthop_group", "acl_table", | |||
| "acl_group", "acl_entry", "acl_counter", "fdb_entry"] %} | |||
| "acl_group", "acl_entry", "acl_counter", "fdb_entry", "snat_entry", "dnat_entry", "ipmc_entry"] %} | |||
There was a problem hiding this comment.
what if snat_entry, dnat, ipmc_entry not enabled in the image? will there be any issue to have crm threshold there?
There was a problem hiding this comment.
Orch will ignore these new entries on the config_db.json with a log message like the one given below.
Nov 24 15:56:48.149727 sonic ERR swss#orchagent: :- handleSetCommand: Failed to parse CRM Config configuration. Unknown attribute snat_entry_low_threshold.
|
All, @arlakshm - this has been quiet for 6 days - can we get some review input so we can move forwards please? The clock is ticking ... |
arlakshm
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Dec 29, 2020
What I did Added support for snat, dnat and ipmc resources under CRM module. Why I did it New feature NAT adds new resources snat_enty and dnat_entry that needs to be monitored. ipmc_entry tracks IP multicast resources used by switch. Associated PRs sonic-net/sonic-utilities/pull/1258 sonic-net/sonic-buildimage#6012 Signed-off-by: Prabhu Sreenivasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prabhu Sreenivasan prabhu.sreenivasan@broadcom
What I did
Added support for snat, dnat and ipmc resources under CRM module.
How I did it
New feature NAT adds new resources snat_enty and dnat_entry that needs to be monitored. ipmc_entry tracks IP multicast resources used by switch.
How to verify it
sonic-utilities tests and crm spytest
Associated PRs
[crm] Add support for snat, dnat and ipmc crm resources sonic-swss#1511
Add support for snat, dnat and ipmc crm resources sonic-utilities#1258