[aclorch] remove error messages in AclRuleMirror::validateAddMatch #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
andriymoroz-mlnx
approved these changes
Jul 19, 2019
stcheng
suggested changes
Jul 19, 2019
|
Oh I see. Can you update swss submodule if it's not included in Sonic buildimage? |
|
@stepanblyschak sonic-net/sonic-buildimage#3190 please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak [email protected]
What I did
Removed error messages in AclRuleMirror::validateAddMatch.
Passing invalid parameter to validateAddMatch is completely valid flow according to design of AclRule*::validateAdd* methods.
Otherwise during everflow testing loganalyzer matches strange errors:
Why I did it
How I verified it
Details if related