Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aclorch] remove error messages in AclRuleMirror::validateAddMatch #984

Closed
wants to merge 1 commit into from
Closed

[aclorch] remove error messages in AclRuleMirror::validateAddMatch #984

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions orchagent/aclorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,16 +976,13 @@ bool AclRuleMirror::validateAddMatch(string attr_name, string attr_value)
if ((m_tableType == ACL_TABLE_L3 || m_tableType == ACL_TABLE_L3V6)
&& attr_name == MATCH_DSCP)
{
SWSS_LOG_ERROR("DSCP match is not supported for the table of type L3");
return false;
}

if ((m_tableType == ACL_TABLE_MIRROR_DSCP &&
aclMatchLookup.find(attr_name) != aclMatchLookup.end() &&
attr_name != MATCH_DSCP))
{
SWSS_LOG_ERROR("%s match is not supported for the table of type MIRROR_DSCP",
attr_name.c_str());
return false;
}

Expand Down Expand Up @@ -1014,8 +1011,6 @@ bool AclRuleMirror::validateAddMatch(string attr_name, string attr_value)
(attr_name == MATCH_SRC_IPV6 || attr_name == MATCH_DST_IPV6 ||
attr_name == MATCH_ICMPV6_TYPE || attr_name == MATCH_ICMPV6_CODE))
{
SWSS_LOG_ERROR("%s match is not supported for the table of type MIRROR",
attr_name.c_str());
return false;
}

Expand All @@ -1024,8 +1019,6 @@ bool AclRuleMirror::validateAddMatch(string attr_name, string attr_value)
attr_name == MATCH_ICMP_TYPE || attr_name == MATCH_ICMP_CODE ||
attr_name == MATCH_ETHER_TYPE))
{
SWSS_LOG_ERROR("%s match is not supported for the table of type MIRRORv6",
attr_name.c_str());
return false;
}

Expand Down