Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arp] copy arp IO to cpu instead of trap and drop #812

Merged
merged 1 commit into from
May 6, 2019
Merged

[arp] copy arp IO to cpu instead of trap and drop #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swssconfig/sample/00-copp.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
{
"COPP_TABLE:trap.group.arp": {
"trap_ids": "arp_req,arp_resp,neigh_discovery",
"trap_action":"trap",
"trap_action":"copy",
Copy link
Contributor

@andriymoroz-mlnx andriymoroz-mlnx Mar 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this crashes on Mellanox switches
please do not merge yet, will clarify with SAI
UPD:
https://github.com/opencomputeproject/SAI/blob/v1.3/inc/saihostif.h#L416
only "trap" and "log" are valid for host interface

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change creates a loop for ICMPv6 RS & NS packets in an L2 MC-LAG scenario as i documented here:
sonic-net/SONiC#1253

"trap_priority":"4",
"queue": "4",
"meter_type":"packets",
Expand Down