[arp] copy arp IO to cpu instead of trap and drop #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During warm reboot, we need VLAN take care of ARP traffic by itself. Signed-off-by: Ying Xie <[email protected]>
|
Just to highlight, there will be now two copies of ARP requests forwarded. One flooded by ASIC and other forwarded by kernel. There is no functional impact but a minor behavioral change. |
prsunny
approved these changes
Mar 10, 2019
|
Thanks for the clarification, Prince! |
| @@ -22,7 +22,7 @@ | |||
| { | |||
| "COPP_TABLE:trap.group.arp": { | |||
| "trap_ids": "arp_req,arp_resp,neigh_discovery", | |||
| "trap_action":"trap", | |||
| "trap_action":"copy", | |||
There was a problem hiding this comment.
this crashes on Mellanox switches
please do not merge yet, will clarify with SAI
UPD:
https://github.com/opencomputeproject/SAI/blob/v1.3/inc/saihostif.h#L416
only "trap" and "log" are valid for host interface
There was a problem hiding this comment.
I think this change creates a loop for ICMPv6 RS & NS packets in an L2 MC-LAG scenario as i documented here:
sonic-net/SONiC#1253
|
this is used for warm reboot only, so we should only do the change before warm reboot, and change it back after warm reboot. |
yxieca
added a commit
that referenced
this pull request
May 6, 2019
During warm reboot, we need VLAN take care of ARP traffic by itself. Signed-off-by: Ying Xie <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…init_cfg.json implicitly (sonic-net#812) * [config/main.py] Modify the load() and reload() functions to load config from config_db.json and init_cfg.json. Signed-off-by: Yong Zhao <[email protected]> * [config/main.py] Undo the changes which load the configuration from init_cfg.json for load() function and define a constant string for the path of init_cfg.json. Signed-off-by: Yong Zhao <[email protected]> * [config/main.py] Correct a typo. Signed-off-by: Yong Zhao <[email protected]> * [config/main.py] Added an else statement in line 551 to decide whether the init_cfg.json exsits or not in reload function. Signed-off-by: Yong Zhao <[email protected]> * [config/main.py] Correct a typo error. Signed-off-by: Yong Zhao <[email protected]> * [config/main.py] Change the loading order and we should first load init_cfg.json and then config_db.json. Signed-off-by: Yong Zhao <[email protected]> * [config/main.py] Use constant string to represent the path of init_cfg.json. Signed-off-by: Yong Zhao <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
This will remove possible deadlock when notification arrives during communication channel destructor thread join.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Switch arp/arp response/neighbor_discovery IO trap action from 'trap' to 'copy'. These IO, instead of trap to CPU and dropped, they will be copy to CPU and forwarded on VLAN.
Why I did it
During warm reboot, we need VLAN take care of ARP traffic by itself.
How I verified it
Tested with matching test: sonic-net/sonic-mgmt#824