Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log verbosity when the capability is not implemented #3240

Merged
merged 2 commits into from
Aug 5, 2024

Merge branch 'master' into fix_path_err_log

b50e37d
Select commit
Loading
Failed to load commit list.
Merged

Reduce log verbosity when the capability is not implemented #3240

Merge branch 'master' into fix_path_err_log
b50e37d
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Azure.sonic-swss succeeded Jul 30, 2024 in 2h 11m 25s

Build #20240730.5 had test failures

Details

Tests

  • Failed: 1 (0.06%)
  • Passed: 1,638 (93.98%)
  • Other: 104 (5.97%)
  • Total: 1,743
Code coverage

  • 40668 of 60736 lines covered (66.96%)

Annotations

Check failure on line 5463 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Azure.sonic-swss

Build log #L5463

Bash exited with code '123'.

Check failure on line 1 in test_PbhRuleUpdate

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Azure.sonic-swss

test_PbhRuleUpdate

AssertionError
Raw output
self = <test_pbh.TestPbhBasicEditFlows object at 0x7f5f7753c460>, testlog = None

    def test_PbhRuleUpdate(self, testlog):
        try:
            # PBH hash field
            pbhlogger.info("Create PBH hash field: {}".format(PBH_HASH_FIELD_NAME))
            self.dvs_pbh.create_pbh_hash_field(
                hash_field_name=PBH_HASH_FIELD_NAME,
                hash_field=PBH_HASH_FIELD_HASH_FIELD,
                sequence_id=PBH_HASH_FIELD_SEQUENCE_ID
            )
            self.dvs_pbh.verify_pbh_hash_field_count(1)
    
            # PBH hash
            pbhlogger.info("Create PBH hash: {}".format(PBH_HASH_NAME))
            self.dvs_pbh.create_pbh_hash(
                hash_name=PBH_HASH_NAME,
                hash_field_list=PBH_HASH_HASH_FIELD_LIST
            )
            self.dvs_hash.verify_hash_count(1)
    
            # PBH table
            pbhlogger.info("Create PBH table: {}".format(PBH_TABLE_NAME))
            self.dvs_pbh.create_pbh_table(
                table_name=PBH_TABLE_NAME,
                interface_list=PBH_TABLE_INTERFACE_LIST,
                description=PBH_TABLE_DESCRIPTION
            )
            self.dvs_acl.verify_acl_table_count(1)
    
            # PBH rule
            attr_dict = {
                "ether_type": PBH_RULE_ETHER_TYPE,
                "ip_protocol": PBH_RULE_IP_PROTOCOL,
                "gre_key": PBH_RULE_GRE_KEY,
                "inner_ether_type": PBH_RULE_INNER_ETHER_TYPE
            }
    
            pbhlogger.info("Create PBH rule: {}".format(PBH_RULE_NAME))
            self.dvs_pbh.create_pbh_rule(
                table_name=PBH_TABLE_NAME,
                rule_name=PBH_RULE_NAME,
                priority=PBH_RULE_PRIORITY,
                qualifiers=attr_dict,
                hash_name=PBH_RULE_HASH
            )
            self.dvs_acl.verify_acl_rule_count(1)
    
            attr_dict = {
                "ether_type": "0x86dd",
                "ipv6_next_header": "0x2f",
                "inner_ether_type": "0x0800"
            }
    
            pbhlogger.info("Update PBH rule: {}".format(PBH_RULE_NAME))
            self.dvs_pbh.update_pbh_rule(
                table_name=PBH_TABLE_NAME,
                rule_name=PBH_RULE_NAME,
                priority="100",
                qualifiers=attr_dict,
                hash_name=PBH_RULE_HASH,
                packet_action="SET_LAG_HASH",
                flow_counter="ENABLED"
            )
    
            hash_id = self.dvs_hash.get_hash_ids(1)[0]
            counter_id = self.dvs_acl.get_acl_counter_ids(1)[0]
    
            sai_attr_dict = {
                "SAI_ACL_ENTRY_ATTR_PRIORITY": self.dvs_acl.get_simple_qualifier_comparator("100"),
                "SAI_ACL_ENTRY_ATTR_FIELD_ETHER_TYPE": self.dvs_acl.get_simple_qualifier_comparator("34525&mask:0xffff"),
                "SAI_ACL_ENTRY_ATTR_FIELD_IP_PROTOCOL": self.dvs_acl.get_simple_qualifier_comparator("disabled"),
                "SAI_ACL_ENTRY_ATTR_FIELD_IPV6_NEXT_HEADER": self.dvs_acl.get_simple_qualifier_comparator("47&mask:0xff"),
                "SAI_ACL_ENTRY_ATTR_FIELD_GRE_KEY": self.dvs_acl.get_simple_qualifier_comparator("disabled"),
                "SAI_ACL_ENTRY_ATTR_FIELD_INNER_ETHER_TYPE": self.dvs_acl.get_simple_qualifier_comparator("2048&mask:0xffff"),
                "SAI_ACL_ENTRY_ATTR_ACTION_SET_ECMP_HASH_ID": self.dvs_acl.get_simple_qualifier_comparator("disabled"),
                "SAI_ACL_ENTRY_ATTR_ACTION_SET_LAG_HASH_ID": self.dvs_acl.get_simple_qualifier_comparator(hash_id),
                "SAI_ACL_ENTRY_ATTR_ACTION_COUNTER": self.dvs_acl.get_simple_qualifier_comparator(counter_id)
            }
    
>           self.dvs_acl.verify_acl_rule_generic(
                sai_qualifiers=sai_attr_dict
            )

test_pbh.py:339: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <dvslib.dvs_acl.DVSAcl object at 0x7f5f775cb670>
sai_qualifiers = {'SAI_ACL_ENTRY_ATTR_ACTION_COUNTER': <function D