-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce log verbosity when the capability is not implemented #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrivantsiv
approved these changes
Jul 20, 2024
@cscarpitta @prsunny Please review |
cscarpitta
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dgsudharsan
approved these changes
Aug 5, 2024
@bingwang-ms Can you please help to cherry-pick this fix to 202405? |
@prsunny FYI |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Aug 22, 2024
…t#3240) Co-authored-by: Sudharsan Dhamal Gopalarathnam <[email protected]>
Cherry-pick PR to 202405: #3261 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Sudharsan Dhamal Gopalarathnam <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did
SAI_SWITCH_ATTR_SUPPORTED_OBJECT_TYPE_LIST is not a mandatory attribute and is not supported in some platforms.
There is an error log seen for such platforms. Reduce noise by changing the verbosity to INFO.
How I verified it
Details if related