Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log verbosity when the capability is not implemented #3240

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

vivekrnv
Copy link
Contributor

Why I did

SAI_SWITCH_ATTR_SUPPORTED_OBJECT_TYPE_LIST is not a mandatory attribute and is not supported in some platforms.

There is an error log seen for such platforms. Reduce noise by changing the verbosity to INFO.

How I verified it

Details if related

@vivekrnv vivekrnv requested a review from prsunny as a code owner July 20, 2024 01:22
@vivekrnv
Copy link
Contributor Author

@cscarpitta @prsunny Please review

Copy link
Contributor

@cscarpitta cscarpitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgsudharsan dgsudharsan merged commit 465391d into sonic-net:master Aug 5, 2024
17 checks passed
@dgsudharsan
Copy link
Collaborator

@bingwang-ms Can you please help to cherry-pick this fix to 202405?

@bingwang-ms
Copy link
Contributor

@prsunny FYI

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3261

mssonicbld pushed a commit that referenced this pull request Aug 22, 2024
@vivekrnv vivekrnv deleted the fix_path_err_log branch August 23, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants