Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switchorch: fixed unsupported attribute causes skipping of processing the rest of the configurations #3209

Merged
merged 1 commit into from
Jul 2, 2024
+8 −1
Merged

switchorch: fixed unsupported attribute causes skipping of processing the rest of the configurations #3209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion orchagent/switchorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,11 +609,18 @@ void SwitchOrch::doAppSwitchTableTask(Consumer &consumer)
invalid_attr = true;
break;
}
if (invalid_attr || unsupported_attr)
if (invalid_attr)
{
/* break from kfvFieldsValues for loop */
SWSS_LOG_ERROR("Invalid Attribute %s", attribute.c_str());
// Will not continue to set the rest of the attributes
break;
}
if (unsupported_attr){
SWSS_LOG_ERROR("Unsupported Attribute %s", attribute.c_str());
// Continue to set the rest of the attributes, even if current attribute is unsupported
continue;
}

sai_status_t status = sai_switch_api->set_switch_attribute(gSwitchId, &attr);
if (status != SAI_STATUS_SUCCESS)
Expand Down
Loading