switchorch: fixed unsupported attribute causes skipping of processing the rest of the configurations #3209
Conversation
…g the rest of configurations Signed-off-by: mazora <[email protected]>
|
@kperumalbfn , can you review/signoff. This was introduced by #3138 |
|
@yxieca Can you please prioritize cherry-pick of this to 202311? This also affected ordered_ecmp attribute being skipped. |
|
Cherry-pick PR to 202311: #3224 |
|
Cherry-pick PR to 202405: #3225 |
…g the rest of configurations (sonic-net#3209) What I did Changed it so that if the configuration has an unsupported attribute, it would continue processing the rest of the configuration rather than break out of the loop and end the processing immediately. Also added syslogs to make it more clear.
…g the rest of configurations (sonic-net#3209) What I did Changed it so that if the configuration has an unsupported attribute, it would continue processing the rest of the configuration rather than break out of the loop and end the processing immediately. Also added syslogs to make it more clear.
|
Hi @amazor, from the PR description, FDB aging will fail to work if missing this PR. But I didn't see any similar issue. Can you please help me understand? |
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
…g the rest of configurations (#3209) What I did Changed it so that if the configuration has an unsupported attribute, it would continue processing the rest of the configuration rather than break out of the loop and end the processing immediately. Also added syslogs to make it more clear.
…g the rest of configurations (sonic-net#3209) What I did Changed it so that if the configuration has an unsupported attribute, it would continue processing the rest of the configuration rather than break out of the loop and end the processing immediately. Also added syslogs to make it more clear.
|
@bingwang-ms, This PR fixes an issue when configuring SWITCH_TABLE:switch table in appl_db. If inside the table you attempt to configure The FDB aging issue only occurs when attempting to use at least one of these two attributes when the ASIC does not support these attributes. These attributes were added in this commit: |
2 similar comments
…g the rest of configurations (#3209) What I did Changed it so that if the configuration has an unsupported attribute, it would continue processing the rest of the configuration rather than break out of the loop and end the processing immediately. Also added syslogs to make it more clear.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
What I did
Changed it so that if the configuration has an unsupported attribute, it would continue processing the rest of the configuration rather than break out of the loop and end the processing immediately.
Also added syslogs to make it more clear.
Why I did it
Would cause FDB aging time to stay default (0) and never cause aging to occur. Fixes this bug in sonic-mgmt: sonic-net/sonic-mgmt#13375
Caused by this commit
https://github.com/sonic-net/sonic-swss/commit/2f8bd9cf6df839abec0ecc9bf31fc9c4b06a6c47How I verified it
TBD
Details if related