Temporarily disable Acl thread to collect counters #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are some issues with the build due to the previous checked in code sonic-net/sonic-sairedis#178. resolve the build issue first and then merge this commit. |
|
@stcheng, does the acl test reads any acl counters? |
|
Yes. Some of the ACL test reads the ACL counters. |
|
I guess we have to disable the acl thread right now, you probably need a local version to keep the acl test running. |
lguohan
approved these changes
May 1, 2017
oleksandrivantsiv
added a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
May 3, 2017
…ers (sonic-net#202)" This reverts commit 2f594c7.
lguohan
pushed a commit
that referenced
this pull request
May 3, 2017
* Revert "[aclorch]: Temporarily disable ACL thread of collecting counters (#202)" This reverts commit 2f594c7. * [acl]: Fix crash in ACL counters thread. Due to incorrect usage of thread class and race conditions from time to time conter thread was accessing AclOrch object members before thay were initialized.
vharish02
pushed a commit
to vharish02/sonic-swss
that referenced
this pull request
Aug 6, 2018
Transceiver monitoring HLD
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
added a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
This reverts commit 2e2ddaf. Issue with bash MAC address is fixed.
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
fix python gcov warning "Please install dotnet core to enable automatic generation of Html report" more info check: sonic-net/sonic-snmpagent#215 Signed-off-by: pettershao-ragilenetworks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to mitigate #201