Skip to content

Commit

Permalink
[aclorch]: Temporarily disable ACL thread of collecting counters (#202)
Browse files Browse the repository at this point in the history
This commit is to mitigate the issue #201.
  • Loading branch information
qiluo-msft authored and Shuotian Cheng committed May 1, 2017
1 parent beff20b commit 2f594c7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 0 additions & 2 deletions orchagent/aclorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,6 @@ bool AclRange::remove()

AclOrch::AclOrch(DBConnector *db, vector<string> tableNames, PortsOrch *portOrch, MirrorOrch *mirrorOrch) :
Orch(db, tableNames),
thread(AclOrch::collectCountersThread, this),
m_portOrch(portOrch),
m_mirrorOrch(mirrorOrch)
{
Expand Down Expand Up @@ -826,7 +825,6 @@ AclOrch::~AclOrch()

m_bCollectCounters = false;
m_sleepGuard.notify_all();
join();
}

void AclOrch::update(SubjectType type, void *cntx)
Expand Down
3 changes: 1 addition & 2 deletions orchagent/aclorch.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

#include <iostream>
#include <sstream>
#include <thread>
#include <mutex>
#include <tuple>
#include <condition_variable>
Expand Down Expand Up @@ -228,7 +227,7 @@ inline void split(string str, Iterable& out, char delim = ' ')
}
}

class AclOrch : public Orch, public Observer, public thread
class AclOrch : public Orch, public Observer
{
public:
AclOrch(DBConnector *db, vector<string> tableNames, PortsOrch *portOrch, MirrorOrch *mirrorOrch);
Expand Down

0 comments on commit 2f594c7

Please sign in to comment.