Enhance dynamic buffer calculation and bug fixes #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove make_pair when calling emplace_back. - The pool size isn't recalculated when a port with headroom override but without speed or cable length configured being shutdown. - Remove the current PG from the old referenced profile only if its name isn't empty, otherwise an entry with empty name will be inserted into m_bufferProfileLookup - Don't try removing statically configured profiles with dynamic headroom from the APPL_DB because they were not programmed to APPL_DB. - Setting a buffer PG to the same profile as it was causes the referenced dynamic profile unable to be removed once it isn't referenced any more Signed-off-by: Stephen Sun <[email protected]>
4 tasks
|
retest this, please |
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
neethajohn
previously approved these changes
Jan 20, 2021
Signed-off-by: Stephen Sun <[email protected]>
neethajohn
approved these changes
Jan 21, 2021
|
retest vs please |
1 similar comment
|
retest vs please |
lguohan
pushed a commit
that referenced
this pull request
Jan 25, 2021
* Enhancement and bug fixes for dynamic buffer calculation What I did - Remove make_pair when calling emplace_back. - The pool size isn't recalculated when a port with headroom override but without speed or cable length configured being shutdown. - Remove the current PG from the old referenced profile only if its name isn't empty, otherwise an entry with empty name will be inserted into m_bufferProfileLookup - Don't try removing statically configured profiles with dynamic headroom from the APPL_DB because they were not programmed to APPL_DB. - Setting a buffer PG to the same profile as it was causes the referenced dynamic profile unable to be removed once it isn't referenced any more How I verified it Run regression and vs test Signed-off-by: Stephen Sun <[email protected]>
DavidZagury
pushed a commit
to DavidZagury/sonic-swss
that referenced
this pull request
Mar 4, 2021
* Enhancement and bug fixes for dynamic buffer calculation What I did - Remove make_pair when calling emplace_back. - The pool size isn't recalculated when a port with headroom override but without speed or cable length configured being shutdown. - Remove the current PG from the old referenced profile only if its name isn't empty, otherwise an entry with empty name will be inserted into m_bufferProfileLookup - Don't try removing statically configured profiles with dynamic headroom from the APPL_DB because they were not programmed to APPL_DB. - Setting a buffer PG to the same profile as it was causes the referenced dynamic profile unable to be removed once it isn't referenced any more How I verified it Run regression and vs test Signed-off-by: Stephen Sun <[email protected]>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Enhancement and bug fixes for dynamic buffer calculation What I did - Remove make_pair when calling emplace_back. - The pool size isn't recalculated when a port with headroom override but without speed or cable length configured being shutdown. - Remove the current PG from the old referenced profile only if its name isn't empty, otherwise an entry with empty name will be inserted into m_bufferProfileLookup - Don't try removing statically configured profiles with dynamic headroom from the APPL_DB because they were not programmed to APPL_DB. - Setting a buffer PG to the same profile as it was causes the referenced dynamic profile unable to be removed once it isn't referenced any more How I verified it Run regression and vs test Signed-off-by: Stephen Sun <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
- What I did Added a field for hardware revision to the psushow output table. - How I did it Defined new psu status field sourced from "revision" field in STATE_DB added in alexrallen/sonic-platform-daemons#1 and adds it to the table output with the header "HW Rev" All relevant unit tests were also updated. - How to verify it Execute show platform psustatus and verify that "HW Rev" column is present and appropriately populated depending on the platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Enhance dynamic buffer calculation and bug fixes
Signed-off-by: Stephen Sun [email protected]
Why I did it
How I verified it
Run regression and vs test
Details if related
- Which release branch to backport (provide reason below if selected)