[psud] Add PSU Hardware Revision to Redis STATE_DB #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
approved these changes
Apr 27, 2021
keboliu
approved these changes
May 6, 2021
liat-grozovik
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
May 23, 2021
- What I did Added a field for hardware revision to the psushow output table. - How I did it Defined new psu status field sourced from "revision" field in STATE_DB added in alexrallen/sonic-platform-daemons#1 and adds it to the table output with the header "HW Rev" All relevant unit tests were also updated. - How to verify it Execute show platform psustatus and verify that "HW Rev" column is present and appropriately populated depending on the platform.
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
- What I did Added a field for hardware revision to the psushow output table. - How I did it Defined new psu status field sourced from "revision" field in STATE_DB added in alexrallen/sonic-platform-daemons#1 and adds it to the table output with the header "HW Rev" All relevant unit tests were also updated. - How to verify it Execute show platform psustatus and verify that "HW Rev" column is present and appropriately populated depending on the platform.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-utilities
that referenced
this pull request
Aug 10, 2021
- What I did Added a field for hardware revision to the psushow output table. - How I did it Defined new psu status field sourced from "revision" field in STATE_DB added in alexrallen/sonic-platform-daemons#1 and adds it to the table output with the header "HW Rev" All relevant unit tests were also updated. - How to verify it Execute show platform psustatus and verify that "HW Rev" column is present and appropriately populated depending on the platform.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
- What I did Added a field for hardware revision to the psushow output table. - How I did it Defined new psu status field sourced from "revision" field in STATE_DB added in alexrallen/sonic-platform-daemons#1 and adds it to the table output with the header "HW Rev" All relevant unit tests were also updated. - How to verify it Execute show platform psustatus and verify that "HW Rev" column is present and appropriately populated depending on the platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added "hardware revision" field to list of platform fields to sync to STATE_DB for the PSU. Also updated relevant unit tests.
Motivation and Context
Now that hardware revision exists as a platform 2.0 field for all devices, it is appropriate to synchronize this field to STATE_DB for PSUs as is done with all other fields. This will allow this field to be exposed to CLI tools through psushow in the future which reads state from STATE_DB.
How Has This Been Tested?
This has been tested on all mellanox platforms aside from MSN2010. Tested by deploying change and verifying that "revision" was present in STATE_DB for all platforms that support it.