Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAI submodule] Updating SAI to v1.9.1 #955

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

vmittal-msft
Copy link
Contributor

Updating sonic-sairedis to point to SAI header 1.9.1.

@vmittal-msft vmittal-msft changed the title Updating SAI to v1.9.1 [SAI submodule] Updating SAI to v1.9.1 Oct 19, 2021
@vmittal-msft vmittal-msft requested review from kcudnik and rlhui October 19, 2021 22:37
@vmittal-msft vmittal-msft marked this pull request as ready for review October 19, 2021 22:39
@vmittal-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 20, 2021

Checkig for white spaces ...
../debian/libsaimetadata-dev/usr/include/sai/saimetadata.h:    _In_ uint64_t flags, 
../debian/libsaimetadata-dev/usr/include/sai/saimetadata.h:    _In_ sai_api_t api, 
../debian/libsaimetadata-dev/usr/include/sai/saimetadata.h:    _In_ sai_object_id_t switch_id, 
../debian/libsaimetadata-dev/usr/include/sai/saimetadata.h:    _In_ sai_object_type_t object_type, 
../debian/libsaimetadata-dev/usr/include/sai/saimetadata.h:    _In_ uint32_t object_count, 

could you also add fix to skip white spaces in debian directory ?
like here:
https://github.com/Azure/sonic-sairedis/blob/master/tests/checkwhitespace.sh#L6

grep -v debian/ |

kcudnik
kcudnik previously approved these changes Oct 20, 2021
@kcudnik
Copy link
Collaborator

kcudnik commented Oct 20, 2021

seems like there is some issue in swss building pipeline:

cp: cannot stat 'sonic-swss/tests/log': No such file or directory
##[error]Bash exited with code '1'.

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 21, 2021

i think this change is good, just for some reason tests timeout

@vmittal-msft
Copy link
Contributor Author

i think this change is good, just for some reason tests timeout

Yes. It looks like other jobs are failing due to same reason.

@vmittal-msft
Copy link
Contributor Author

i think this change is good, just for some reason tests timeout

Yes. It looks like other jobs are failing due to same reason. I have pinged @xumia about this. He mentioned that fix has been pushed last night but it doesn't seem to work.

@vmittal-msft vmittal-msft merged commit 433c8df into sonic-net:master Oct 21, 2021
@vmittal-msft vmittal-msft deleted the sairedis-sai-1.9.1 branch October 21, 2021 22:41
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants