Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-sairedis submodule] Update SAI header to ver 1.9.1 for MLNX SDK/SAI #9012

Merged

Conversation

vmittal-msft
Copy link
Contributor

@vmittal-msft vmittal-msft commented Oct 19, 2021

Why I did it

To update SAI header to ver 1.9.1 and corresponding MLNX SAI

How I did it

Updated sonic-sairedis to point to new SAI 1.9.1 header
Updated MLNX SAI/SDK supporting new header

How to verify it

Image built successfully.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Copy link
Contributor

@rlhui rlhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see sonic-sairedis submodule update here.

@vmittal-msft
Copy link
Contributor Author

I do not see sonic-sairedis submodule update here.

I am waiting for this PR to merge - sonic-net/sonic-sairedis#955 before i can update sonic-sairedis hence kept this PR in draft state.

@vmittal-msft vmittal-msft force-pushed the vmittal/SAIREDIS-SAI_1.9.1 branch from 9b1e36e to 990feb4 Compare October 22, 2021 00:28
@vmittal-msft vmittal-msft marked this pull request as ready for review October 22, 2021 00:31
@vmittal-msft vmittal-msft requested a review from lguohan as a code owner October 22, 2021 00:31
@smaheshm
Copy link
Contributor

@vmittal-msft It's good to do basic sanity of the image on a mellanox switch. You can get the image from the build result above.

@smaheshm
Copy link
Contributor

@vmittal-msft It's good to do basic sanity of the image on a mellanox switch. You can get the image from the build result above.

The above image may not be the right one if sonic-sairedis is not updated yet.

@vmittal-msft vmittal-msft merged commit 8b5f33d into sonic-net:master Oct 22, 2021
@vmittal-msft vmittal-msft deleted the vmittal/SAIREDIS-SAI_1.9.1 branch October 22, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants