Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAI submodule update to bring saithrift changes for syncd bookworm #1370

Merged

Conversation

Keshavg-marvell
Copy link
Contributor

SAI submodule update to bring saithrift changes needed for syncd bookworm migration

kcudnik
kcudnik previously approved these changes Apr 4, 2024
@kcudnik
Copy link
Collaborator

kcudnik commented Apr 4, 2024

please fix build errors

Signed-off-by: Keshav Gupta <[email protected]>
@Keshavg-marvell Keshavg-marvell force-pushed the update_sai_for_syncd_bookworm branch from ce54f97 to d45e296 Compare April 9, 2024 09:27
@Keshavg-marvell
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Keshav Gupta <[email protected]>
@Keshavg-marvell Keshavg-marvell force-pushed the update_sai_for_syncd_bookworm branch from 547001c to e00118b Compare April 10, 2024 06:58
@liat-grozovik
Copy link
Collaborator

@kcudnik @saiarcot895 please help to merge. i have no such permsion

@saiarcot895 saiarcot895 merged commit c41a0cb into sonic-net:master Apr 15, 2024
17 checks passed
saiarcot895 added a commit to saiarcot895/sonic-buildimage that referenced this pull request Apr 17, 2024
This submodule update needs to go as part of this change because it
would break compatibility with Bullseye for MACsec, but adds
compatibility for Bookworm, which is what is needed here.

This brings in the following commits:

```
73ada8d5 Fix SSCI parameter when creating MACsec tunnels on Bookworm (sonic-net/sonic-sairedis#1372)
c41a0cb9 SAI submodule update to bring saithrift changes for syncd bookworm (sonic-net/sonic-sairedis#1370)
be47489f Add Bookworm build to PR checks (sonic-net/sonic-sairedis#1371)
d9ba01b5 Update ip commands for MACsec for Bookworm (sonic-net/sonic-sairedis#1368)
```

Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Apr 22, 2024
* Upgrade VS syncd to Bookworm

As part of this, iproute2 is no longer compiled here, since the
macsec patch is now in version 6.1. In addition, for docker-sonic-vs,
version 6.1 of iproute2 is pulled from the bullseye-backports repo.

* Update sonic-sairedis submodule

This submodule update needs to go as part of this change because it
would break compatibility with Bullseye for MACsec, but adds
compatibility for Bookworm, which is what is needed here.

This brings in the following commits:

```
73ada8d5 Fix SSCI parameter when creating MACsec tunnels on Bookworm (sonic-net/sonic-sairedis#1372)
c41a0cb9 SAI submodule update to bring saithrift changes for syncd bookworm (sonic-net/sonic-sairedis#1370)
be47489f Add Bookworm build to PR checks (sonic-net/sonic-sairedis#1371)
d9ba01b5 Update ip commands for MACsec for Bookworm (sonic-net/sonic-sairedis#1368)
```

Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants