-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAI submodule update to bring saithrift changes for syncd bookworm #1370
Merged
saiarcot895
merged 5 commits into
sonic-net:master
from
Keshavg-marvell:update_sai_for_syncd_bookworm
Apr 15, 2024
Merged
SAI submodule update to bring saithrift changes for syncd bookworm #1370
saiarcot895
merged 5 commits into
sonic-net:master
from
Keshavg-marvell:update_sai_for_syncd_bookworm
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncd Signed-off-by: Keshav Gupta <[email protected]>
kcudnik
previously approved these changes
Apr 4, 2024
please fix build errors |
Signed-off-by: Keshav Gupta <[email protected]>
Keshavg-marvell
force-pushed
the
update_sai_for_syncd_bookworm
branch
from
April 9, 2024 09:27
ce54f97
to
d45e296
Compare
/azpw run Azure.sonic-sairedis |
/AzurePipelines run Azure.sonic-sairedis |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Keshav Gupta <[email protected]>
Keshavg-marvell
force-pushed
the
update_sai_for_syncd_bookworm
branch
from
April 10, 2024 06:58
547001c
to
e00118b
Compare
kcudnik
approved these changes
Apr 10, 2024
Merged
11 tasks
@kcudnik @saiarcot895 please help to merge. i have no such permsion |
kcudnik
approved these changes
Apr 14, 2024
saiarcot895
approved these changes
Apr 15, 2024
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Apr 17, 2024
This submodule update needs to go as part of this change because it would break compatibility with Bullseye for MACsec, but adds compatibility for Bookworm, which is what is needed here. This brings in the following commits: ``` 73ada8d5 Fix SSCI parameter when creating MACsec tunnels on Bookworm (sonic-net/sonic-sairedis#1372) c41a0cb9 SAI submodule update to bring saithrift changes for syncd bookworm (sonic-net/sonic-sairedis#1370) be47489f Add Bookworm build to PR checks (sonic-net/sonic-sairedis#1371) d9ba01b5 Update ip commands for MACsec for Bookworm (sonic-net/sonic-sairedis#1368) ``` Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 22, 2024
* Upgrade VS syncd to Bookworm As part of this, iproute2 is no longer compiled here, since the macsec patch is now in version 6.1. In addition, for docker-sonic-vs, version 6.1 of iproute2 is pulled from the bullseye-backports repo. * Update sonic-sairedis submodule This submodule update needs to go as part of this change because it would break compatibility with Bullseye for MACsec, but adds compatibility for Bookworm, which is what is needed here. This brings in the following commits: ``` 73ada8d5 Fix SSCI parameter when creating MACsec tunnels on Bookworm (sonic-net/sonic-sairedis#1372) c41a0cb9 SAI submodule update to bring saithrift changes for syncd bookworm (sonic-net/sonic-sairedis#1370) be47489f Add Bookworm build to PR checks (sonic-net/sonic-sairedis#1371) d9ba01b5 Update ip commands for MACsec for Bookworm (sonic-net/sonic-sairedis#1368) ``` Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAI submodule update to bring saithrift changes needed for syncd bookworm migration