Update ip commands for MACsec for Bookworm #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bookworm's iproute2 has built-in support for configuring MACsec with XPN ciphers. Unfortunately, the syntax is slightly different, which means changes are needed for this to work on Bookworm. Update the iproute2 commands run for Bookworm. This does mean compatibility with Bullseye will break. Signed-off-by: Saikrishna Arcot <[email protected]>
11 tasks
Pterosaur
previously approved these changes
Apr 3, 2024
|
you can add tests in the same PR, you dont need extra pr just for tests |
Yes, but I'm not sure whether my changes will fix this coverage issue, Meanwhile, I feel I don't have the write permission for this PR. |
Signed-off-by: Ze Gan <[email protected]>
kcudnik
approved these changes
Apr 4, 2024
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Apr 10, 2024
This submodule update needs to go as part of this change because it would break compatibility with Bullseye for MACsec, but adds compatibility for Bookworm, which is what is needed here. This brings in the following commit: ``` d9ba01b5 Update ip commands for MACsec for Bookworm (sonic-net/sonic-sairedis#1368) ``` Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Apr 17, 2024
This submodule update needs to go as part of this change because it would break compatibility with Bullseye for MACsec, but adds compatibility for Bookworm, which is what is needed here. This brings in the following commits: ``` 73ada8d5 Fix SSCI parameter when creating MACsec tunnels on Bookworm (sonic-net/sonic-sairedis#1372) c41a0cb9 SAI submodule update to bring saithrift changes for syncd bookworm (sonic-net/sonic-sairedis#1370) be47489f Add Bookworm build to PR checks (sonic-net/sonic-sairedis#1371) d9ba01b5 Update ip commands for MACsec for Bookworm (sonic-net/sonic-sairedis#1368) ``` Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 22, 2024
* Upgrade VS syncd to Bookworm As part of this, iproute2 is no longer compiled here, since the macsec patch is now in version 6.1. In addition, for docker-sonic-vs, version 6.1 of iproute2 is pulled from the bullseye-backports repo. * Update sonic-sairedis submodule This submodule update needs to go as part of this change because it would break compatibility with Bullseye for MACsec, but adds compatibility for Bookworm, which is what is needed here. This brings in the following commits: ``` 73ada8d5 Fix SSCI parameter when creating MACsec tunnels on Bookworm (sonic-net/sonic-sairedis#1372) c41a0cb9 SAI submodule update to bring saithrift changes for syncd bookworm (sonic-net/sonic-sairedis#1370) be47489f Add Bookworm build to PR checks (sonic-net/sonic-sairedis#1371) d9ba01b5 Update ip commands for MACsec for Bookworm (sonic-net/sonic-sairedis#1368) ``` Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookworm's iproute2 has built-in support for configuring MACsec with XPN ciphers. Unfortunately, the syntax is slightly different, which means changes are needed for this to work on Bookworm.
Update the iproute2 commands run for Bookworm. This does mean compatibility with Bullseye will break.