Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lgtm] Fix libyang missing in lgtm validation issue #1135

Merged
merged 3 commits into from
Oct 3, 2022
Merged

[lgtm] Fix libyang missing in lgtm validation issue #1135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2a27d8
Fix libyang missing in lgtm validation issue
liuh-80 Oct 2, 2022
f787b79
Fix by pr comments
liuh-80 Oct 2, 2022
fed4699
Fix lgtm run UT issue
liuh-80 Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lgtm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ extraction:
- libgmock-dev
- uuid
- uuid-dev
- libyang-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libyang-dev one package is enough?

Copy link
Contributor Author

@liuh-80 liuh-80 Oct 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check the make file of sonic-sairedis, we need install libyang, because there was step to run UT in make file, so need load libyang during UT.

- libyang
after_prepare:
- ls -l
- git clone https://github.com/Azure/sonic-swss-common; pushd sonic-swss-common; ./autogen.sh; fakeroot dpkg-buildpackage -us -uc -b; popd
Expand Down