[lgtm] Fix libyang missing in lgtm validation issue #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The LGTM validation always using master branch file, so please help do a force merge to fix this issue. |
qiluo-msft
reviewed
Oct 2, 2022
| @@ -21,6 +21,8 @@ extraction: | |||
| - libgmock-dev | |||
| - uuid | |||
| - uuid-dev | |||
| - libyang | |||
| - libyang-dev | |||
There was a problem hiding this comment.
libyang-dev one package is enough?
There was a problem hiding this comment.
I check the make file of sonic-sairedis, we need install libyang, because there was step to run UT in make file, so need load libyang during UT.
kcudnik
approved these changes
Oct 3, 2022
qiluo-msft
approved these changes
Oct 3, 2022
|
@kcudnik The LGTM validation always using master branch file, so please help do a force merge to fix this issue. |
kcudnik
approved these changes
Oct 3, 2022
7 tasks
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* Fix libyang missing in lgtm validation issue
skbarista
added a commit
to skbarista/sonic-sairedis
that referenced
this pull request
Dec 2, 2022
* Add UnitTest. * Port sonic-net#1135 to 202205 to fix lgtm.
Yakiv-Huryk
pushed a commit
to Yakiv-Huryk/sonic-sairedis
that referenced
this pull request
Dec 6, 2022
* Fix libyang missing in lgtm validation issue
xumia
pushed a commit
that referenced
this pull request
Dec 29, 2022
* Add UnitTest. * Port #1135 to 202205 to fix lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
sonic-swss-common lib will add depency to libyang soon, so need install libyang lib to prevent lgtm break.
How I did it
Modify azure pipeline to install libyang in lgtm steps.
How to verify it
Pass lgtm validation.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Modify lgtm.yml to install libyang in lgtm.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)